Making json_encode() always produce a non-empty-string, when successful
#8681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
added
the
release:fix
|
Would you please target this against master, we'll be releasing 5 in the coming days anyway :) |
|
Sure thing: I targeted 4.x because I thought it would still apply 😁 |
Ocramius
force-pushed
the
stubs/better-json-encode-types
branch
from
096a86c
to
2fd7a1a
Compare
|
@danog done |
|
I don't get how the CI go bonkers everytime there's a switch like that... Sorry Marco, could you do a rebase on master to relaunch the CI please? |
|
It's already rebased :| Lemme add some gibberish to the patch, like whitespace to the commit. |
…essful `json_encode()` never produces `''` as a value: that would be invalid JSON anyway
Ocramius
force-pushed
the
stubs/better-json-encode-types
branch
from
2fd7a1a
to
5e9b921
Compare
|
Seems working :) Thanks! |
|
Thanks! |
|
Thank you for merging so quickly! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_encode()never produces''as a value: that would be invalid JSON anyway