Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stringable-object equivalent to Stringable #8688

Merged
merged 2 commits into from Nov 11, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Nov 9, 2022

Fixes #8575
Supersedes #8595

There were a number of problems with stringable-object (object{__tostring()}) type used by implode/join stubs:

  1. stringable-object type is repesented internally as object{__tostring()} (lowercase), but checks in various places were using __toString casing (note the capital S).
  2. There was no support for checking sub/supertypes involving stringable-object and Stringable interface.

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 9, 2022
@weirdan weirdan merged commit f49ff60 into vimeo:master Nov 11, 2022
@weirdan weirdan deleted the fix-stringable-object branch November 11, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implode does not complain about a list of non-stringable objects
1 participant