Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve cache flush debug info and code if cache disabled #8707

Merged
merged 2 commits into from Nov 18, 2022

Conversation

kkmuffme
Copy link
Contributor

When debugging the message didn't make sense when no cache directory exists yet, wasting time debugging why a config file changed (even though it didn't change, the cache just wasn't populated yet)

Also remove some duplicate code and bail earlier if cache directory is null, since all subsequent calls need it to not be null

@kkmuffme kkmuffme marked this pull request as ready for review November 15, 2022 09:51
@kkmuffme
Copy link
Contributor Author

Please merge

@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Nov 18, 2022
@orklah
Copy link
Collaborator

orklah commented Nov 18, 2022

Thanks!

@orklah orklah merged commit 4a83f88 into vimeo:master Nov 18, 2022
@kkmuffme kkmuffme deleted the improve-cache-flush-debug-info branch November 20, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants