add --no-progress to psalter #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like exists in Psalm.php
|
Please merge |
orklah
reviewed
Nov 15, 2022
| if ($debug) { | ||
| $progress = new DebugProgress(); | ||
| } elseif (isset($options['no-progress'])) { | ||
| $progress = new VoidProgress(); |
There was a problem hiding this comment.
you seem to be missing an import for VoidProgress here
There was a problem hiding this comment.
Thanks, added.
In v4 circleci would have complained about that, is there maybe a bug with it in v5?
There was a problem hiding this comment.
I'm not sure it's classified as Code Style issue given it was an outright bug (Can php cs even know this class does not exists in this namespace??)
There was a problem hiding this comment.
I'm 99.9% sure it previously complained for missing "use" statements in 4.x branch
orklah
added
the
release:feature
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like exists in Psalm.php