Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade humbug/box #8770

Merged
merged 5 commits into from Nov 26, 2022
Merged

Upgrade humbug/box #8770

merged 5 commits into from Nov 26, 2022

Commits on Nov 26, 2022

  1. Centralize version data access 

    Obtaining package version data from within a scoped PHAR file is a
complicated topic, and it's been alternatively broken and fixed multiple
times.

This change moves version data access to a single class, so that we can
fix it there should we need to.

The rest of the code can just rely on PSALM_VERSION constant (which will
be made unscoped in a further commit) or call `VersionUtils` methods.
    @weirdan
    weirdan committed Nov 26, 2022
    Copy the full SHA
    1555554 View commit details
    Browse the repository at this point in the history

  2. Update humbug/box 

    It updates humbug/scoper as well, so some changes to scoper
configuration are required.

`PSALM_VERSION` and `PHP_PARSER_VERSION` constants are made unscoped to
prevent various issues.
    @weirdan
    weirdan committed Nov 26, 2022
    Copy the full SHA
    369ba06 View commit details
    Browse the repository at this point in the history

  3. Bake version data into PHAR file 

    Compatibility between `ocramius/package-versions`,
`composer/package-versions-deprecated`, `composer-runtime-api` and
`humbug/box` (with `humbug/scoper` further complicating things)has been
always a problematic area. So instead of trying to keep up with all the
changes in all of those packages, we will now bake the version data (for
the packages we need) into the PHAR file itself.

Fixes vimeo#7606
Fixes vimeo#5399
    @weirdan
    weirdan committed Nov 26, 2022
    Copy the full SHA
    683fe2f View commit details
    Browse the repository at this point in the history

  4. SA and CS fixes

    @weirdan
    weirdan committed Nov 26, 2022
    Copy the full SHA
    ee34d15 View commit details
    Browse the repository at this point in the history

  5. Disable parallel PHAR build 

    This is an attempt to fix CirleCI issue in this build:
https://app.circleci.com/pipelines/github/weirdan/psalm/666/workflows/33476cb1-d753-4e2d-b067-a5c92808d725/jobs/2457
    @weirdan
    weirdan committed Nov 26, 2022
    Copy the full SHA
    5cbe241 View commit details
    Browse the repository at this point in the history