Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables should outlive namespaces #8779

Merged
merged 1 commit into from Nov 27, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Nov 27, 2022

Variables in PHP are not namespaced. In other words, namespaces share the context with the file they are located in.

See https://3v4l.org/2qvrC

Fixes #8778

Depends on #8780

Variables in PHP are not namespaced. In other words, namespaces share
the context with the file they are located in.

See https://3v4l.org/2qvrC

Fixes vimeo#8778
@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 27, 2022
@weirdan weirdan marked this pull request as ready for review November 27, 2022 09:03
@muglug muglug merged commit 8fa35c2 into vimeo:master Nov 27, 2022
@muglug
Copy link
Collaborator

muglug commented Nov 27, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables should not be namespaced
2 participants