Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dynamic property on LanguageServer #8876

Merged
merged 2 commits into from Dec 10, 2022
Merged

Fixed dynamic property on LanguageServer #8876

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94003a3
Fixed dynamic property on LanguageServer
weirdan Dec 10, 2022
d19759c
Suppress irrelevant Psalm issue
weirdan Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Psalm/Internal/LanguageServer/LanguageServer.php
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@
use Amp\Success;
use Generator;
use InvalidArgumentException;
use JsonMapper;
use LanguageServerProtocol\ClientCapabilities;
use LanguageServerProtocol\CompletionOptions;
use LanguageServerProtocol\Diagnostic;
Expand Down Expand Up @@ -108,6 +109,13 @@ class LanguageServer extends Dispatcher
*/
protected $current_issues = [];

/**
* This should actually be a private property on `parent`
* @psalm-suppress UnusedProperty
* @var JsonMapper
*/
protected $mapper;

public function __construct(
ProtocolReader $reader,
ProtocolWriter $writer,
Expand Down