Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last property typehints #8910

Merged
merged 2 commits into from Dec 17, 2022
Merged

Conversation

jack-worman
Copy link
Contributor

Should be everything without breaking BC

@orklah
Copy link
Collaborator

orklah commented Dec 16, 2022

Thanks! Could you make another sweep of performance check?

phpcs.xml Show resolved Hide resolved
@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Dec 16, 2022
Copy link
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jack-worman
Copy link
Contributor Author

Thanks! Could you make another sweep of performance check?

OLD (v5.2.0):
230.14s user 20.82s system 285% cpu 1:27.77 total
228.89s user 20.20s system 295% cpu 1:24.40 total
232.80s user 19.65s system 294% cpu 1:25.61 total
232.18s user 20.11s system 296% cpu 1:25.19 total
233.24s user 19.62s system 297% cpu 1:24.93 total
235.84s user 19.35s system 296% cpu 1:26.10 total

NEW (this branch):
226.39s user 20.13s system 296% cpu 1:23.03 total
239.85s user 22.12s system 284% cpu 1:32.00 total
236.67s user 20.63s system 291% cpu 1:28.34 total
243.50s user 21.69s system 286% cpu 1:32.49 total
239.61s user 20.60s system 295% cpu 1:28.07 total
224.56s user 19.75s system 289% cpu 1:24.50 total
213.04s user 17.40s system 302% cpu 1:16.12 total

Again, basically the same aside.

@jack-worman
Copy link
Contributor Author

Another test, but this time I closed out of other programs and didn't stream a twitch,

OLD:
real    1m18.422s user    3m38.936s sys     0m17.202s
real    1m15.243s user    3m33.943s sys     0m16.369s
real    1m14.178s user    3m25.938s sys     0m15.956s
real    1m13.769s user    3m25.643s sys     0m15.819s
real    1m19.965s user    3m37.302s sys     0m16.893s
real    1m12.128s user    3m23.238s sys     0m15.830s

NEW:                                                
real    1m12.951s user    3m26.481s sys     0m15.885s
real    1m12.857s user    3m25.852s sys     0m15.832s
real    1m12.813s user    3m25.501s sys     0m15.834s
real    1m20.767s user    3m37.414s sys     0m17.310s
real    1m20.317s user    3m43.043s sys     0m21.136s
real    1m13.754s user    3m26.978s sys     0m16.150s

@orklah orklah merged commit 62ced63 into vimeo:master Dec 17, 2022
@orklah
Copy link
Collaborator

orklah commented Dec 17, 2022

Thanks!

@jack-worman jack-worman deleted the Last_property_typehints branch December 17, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants