New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last property typehints #8910
Merged
Merged
Last property typehints #8910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! Could you make another sweep of performance check? |
weirdan
reviewed
Dec 16, 2022
weirdan
reviewed
Dec 16, 2022
weirdan
added
the
release:internal
The PR will be included in 'Internal changes' section of the release notes
label
Dec 16, 2022
weirdan
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Again, basically the same aside. |
Another test, but this time I closed out of other programs and didn't stream a twitch, OLD:
real 1m18.422s user 3m38.936s sys 0m17.202s
real 1m15.243s user 3m33.943s sys 0m16.369s
real 1m14.178s user 3m25.938s sys 0m15.956s
real 1m13.769s user 3m25.643s sys 0m15.819s
real 1m19.965s user 3m37.302s sys 0m16.893s
real 1m12.128s user 3m23.238s sys 0m15.830s
NEW:
real 1m12.951s user 3m26.481s sys 0m15.885s
real 1m12.857s user 3m25.852s sys 0m15.832s
real 1m12.813s user 3m25.501s sys 0m15.834s
real 1m20.767s user 3m37.414s sys 0m17.310s
real 1m20.317s user 3m43.043s sys 0m21.136s
real 1m13.754s user 3m26.978s sys 0m16.150s |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be everything without breaking BC