Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReflectionClass stub #8930

Merged
merged 1 commit into from Dec 18, 2022
Merged

Conversation

VincentLanglet
Copy link
Contributor

While trying dev-master branch, I got a new error @orklah
https://psalm.dev/r/364700858b

Those stubs were introduced in #8722 (cc @Ocramius)
and this is the only mistake I found.

@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/364700858b
<?php

$reflection = new \ReflectionClass((string) rand(0, 1));
$property = $reflection->getProperty('types');
Psalm output (using commit 8223332):

ERROR: TooManyArguments - 4:26 - Too many arguments for ReflectionClass::getProperty - expecting 0 but saw 1

INFO: UnusedVariable - 4:1 - $property is never referenced or the value is not used

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 18, 2022
@orklah
Copy link
Collaborator

orklah commented Dec 18, 2022

Thanks!

@orklah orklah merged commit b6faa3e into vimeo:master Dec 18, 2022
@VincentLanglet VincentLanglet deleted the reflectionClass branch December 18, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants