Allow conditions inside loops to preserve or narrow int range #8934
+32
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorejb
force-pushed
the
fix-loop-int-range
branch
from
2aaea01 to
4027c43
Compare
theodorejb
changed the title
danog
added
the
release:fix
orklah
reviewed
Dec 18, 2022
theodorejb
force-pushed
the
fix-loop-int-range
branch
from
4027c43 to
2a377ef
Compare
theodorejb
force-pushed
the
fix-loop-int-range
branch
from
2a377ef to
0f4db69
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7555, fixes #8020, fixes #8534, fixes #8838, fixes #8865
I lack familiarity with the assertion reconciler code, so I'm not sure if there is something the continue if
$inside_loopchecks were necessary for. But at least the current tests still seem to pass without them, and this fixes issues where conditions inside a loop failed to preserve or narrow the range of an int as expected.