Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix implicit return type #9026

Merged
merged 12 commits into from Jan 7, 2023
Merged

fix implicit return type #9026

merged 12 commits into from Jan 7, 2023

Commits on Jan 5, 2023

  1. fix implicit return type 

    * fix implicit void return type errors https://psalm.dev/r/b0e397c14e
* fix void + never = null return type error https://psalm.dev/r/6f227ae9b9
* fixes vimeo#8912 and vimeo#8862
    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    4dd92fb View commit details
    Browse the repository at this point in the history

  2. fix TypeCombiner void => null from docblock missing property 

    * fix InvalidReturnType "Not all code paths of" when function returns null combined types (void, never) https://psalm.dev/r/db4e313898
* fix false positive InvalidReturnType for void|never phpdoc when function returns void and exits
    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    1341c15 View commit details
    Browse the repository at this point in the history

  3. fix void => null wrong condition 

    * fix void => null to greedy suppressing errors in never cases
* fix test allowNoReturnInSubclassWithNullableReturnType to not fail
    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    67e6cb8 View commit details
    Browse the repository at this point in the history

  4. class overrides stubbed should be ignored too

    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    13f6258 View commit details
    Browse the repository at this point in the history

  5. code style

    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    4c0cae7 View commit details
    Browse the repository at this point in the history

  6. suppress psalm bug

    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    6b98160 View commit details
    Browse the repository at this point in the history

  7. Fix psalter bug changing to native types even when backwards incompat… 

    …ible is false
    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    a0aff18 View commit details
    Browse the repository at this point in the history

  8. Revert "Fix psalter bug changing to native types even when backwards … 

    …incompatible is false"

This reverts commit 98e22c2.
    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b85d637 View commit details
    Browse the repository at this point in the history

  9. add null to tests to fix invalid return type

    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    25cadb6 View commit details
    Browse the repository at this point in the history

  10. fix "No return statements were found" not reporting

    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    ea1ece5 View commit details
    Browse the repository at this point in the history

  11. code style

    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    2bfdf9b View commit details
    Browse the repository at this point in the history

  12. fix test should not change phpdoc to native type hint but keep phpdoc

    @kkmuffme
    kkmuffme committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    d430145 View commit details
    Browse the repository at this point in the history