Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not report required closure arguments as unused #9629

Merged
merged 5 commits into from
Apr 10, 2023
Merged

Do not report required closure arguments as unused #9629

merged 5 commits into from
Apr 10, 2023

Commits on Apr 9, 2023

  1. qa: restructure UnusedVariableTest 

    This aligns with most recent tests which do consume `InvalidCodeAnalysisTestTrait` and `ValidCodeAnalysisTestTrait`.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    803786e View commit details
    Browse the repository at this point in the history

  2. qa: introduce failing test for vimeo#8095 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    3a9817a View commit details
    Browse the repository at this point in the history

  3. qa: add another test to verify required arguments are not being reported 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    707a0ba View commit details
    Browse the repository at this point in the history

  4. bugfix: do not report required closure arguments as unused 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    6d5f999 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. qa: raise php_version in ValidCodeAnalysisTestTrait and 

    `InvalidCodeAnalysisTestTrait`  to 7.4

This synchronizes with the minimum of the supported PHP versions via `composer.json` requirements.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    e5ae26d View commit details
    Browse the repository at this point in the history