Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mixed replace return types for arrays #9981

Merged
merged 6 commits into from
Jul 2, 2023
Merged

fix mixed replace return types for arrays #9981

merged 6 commits into from
Jul 2, 2023

Commits on Jun 30, 2023

  1. fix mixed replace return types for arrays 

    * remove useless replace return type provider code that returned incorrect type for array replacements and was worse duplicate of existing stubs
* require preg patterns to be non-empty-strings as otherwise it will throw a PHP notice
* improve return type of array replacements to be more correct (not fully correct due to vimeo#5994 (comment))
    @kkmuffme
    kkmuffme committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    26eb870 View commit details
    Browse the repository at this point in the history

  2. code style

    @kkmuffme
    kkmuffme committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    09a3b4b View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. fix failing tests and shepherd

    @kkmuffme
    kkmuffme committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    c2388b4 View commit details
    Browse the repository at this point in the history

  2. more code style and shepherd

    @kkmuffme
    kkmuffme committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    7593b5b View commit details
    Browse the repository at this point in the history

  3. improve config validation and fix wrong condition

    @kkmuffme
    kkmuffme committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d24df1a View commit details
    Browse the repository at this point in the history

  4. code style

    @kkmuffme
    kkmuffme committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    0377dd9 View commit details
    Browse the repository at this point in the history