Update ghc to version 9. Add XDG support. #98
Conversation
There was a problem hiding this comment.
Thank you.
I'd strongly prefer for this to be separate PRs: one for the version bump and one for the feature. It's not a huge deal here, but in general the bar is much lower for integrating a simple version bump on its own than if it has to be taken together with code changes/features.
I added some minor nits for you to consider.
| @@ -504,7 +504,7 @@ commands = [ | |||
| MPD.previous :: Vimus () | |||
|
|
|||
| , command "toggle" "toggle between play and pause" $ do | |||
| MPDE.toggle :: Vimus () | |||
| MPD.toggle :: Vimus () | |||
There was a problem hiding this comment.
This change appears unrelated to the PR.
There was a problem hiding this comment.
When set to MPDE it doesn't compile because the MPDE module does not have the toggle function, I changed it so I could compile and then forgot about it
| -- overwrite possible config errors | ||
| mvwaddstr inputWindow 0 0 "type :quit to exit, :help for help" | ||
| return () | ||
| mvwaddstr inputWindow 0 0 "type :quit to exit, :help for help" |
There was a problem hiding this comment.
This change appears unrelated to the PR
There was a problem hiding this comment.
I have no idea how this happened, will indent back
There was a problem hiding this comment.
I have no idea how this happened, will indent back
| @@ -193,18 +195,27 @@ run host port ignoreVimusrc = do | |||
| -- load default mappings | |||
| Command.runCommand "runtime default-mappings" | |||
|
|
|||
| -- source ~/.vimusrc | |||
| configHome <- liftIO $ getEnv "XDG_CONFIG_HOME" | |||
There was a problem hiding this comment.
I don't feel too strongly about it but this could do with some golfing to make it a little more succinct/easier to follow. Like: take a list of alternatives and try each in order.
There was a problem hiding this comment.
the only other way i can think of doing this is using the xdgdirectories thing but i have to add an extra package for that i think
There was a problem hiding this comment.
also sorry for the late responses but july and august were heavy months for me
title says it all.