Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags generation when wiki extension has multiple dots #1401

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MartyLake
Copy link

When using extension containing multiple dots, for example .wiki.txt, generated tags would contains a faulty links that ends with piece of the extension, for example .wiki, then vimwiki would try to go to a file that ends with .wiki.wiki.txt instead.

This patch solves the issue by removing the exact suffix of the extension instead of using the root filename modifier.

Steps for submitting a pull request:

  • ALL pull requests should be made against the dev branch!
  • Take a look at CONTRIBUTING.MD
  • Reference any related issues.
  • Provide a description of the proposed changes.
  • PRs must pass Vint tests and add new Vader tests as applicable.
  • Make sure to update the documentation in doc/vimwiki.txt if applicable,
    including the Changelog and Contributors sections.

When using extension containing multiple dots, for example `.wiki.txt`, generated tags would contains a faulty links that ends with piece of the extension, for example `.wiki`, then vimwiki would try to go to a file that ends with `.wiki.wiki.txt` instead.

This patch solves the issue by removing the exact suffix of the extension instead of using the root filename modifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant