Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ONCE environment variable ignorance #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dieselburner
Copy link

@dieselburner dieselburner commented Jul 11, 2023

Hi there,

Here's the MR to fix the issue I have faced with ONCE environment variable being ignored, when executed via Docker.

One important note: this changes docker-compose-watcher (or, in fact, compose-updater) default value of once to false, so that it would be possible to remove -once=0 from Dockerfile, but still keeping the old behavior:

CMD ["docker-compose-watcher", "-once=0", "-printSettings"]

The reason of removing this argument from CMD above is rather simple: due to code structure command line arguments takes precedence over environment variables, which I think is the right way to go. However, keeping -once=0 will prevent ability to override behavior of passing environment variable ONCE to Docker.

Basically, this MR makes everyone happy.

Few other small things irrelevant to original issue comes as a bonus.

@dieselburner
Copy link
Author

@virtualzone I would appreciate if you could review this and merge, or provide comments what needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant