Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Storagecontrol): Adding new library sample #5

Closed
wants to merge 1 commit into from
Closed

feat(Storagecontrol): Adding new library sample #5

wants to merge 1 commit into from

Conversation

vishwarajanand
Copy link
Owner

Fixes googleapis/google-cloud-php#7243

Storagecontrol Library already created googleapis/google-cloud-php#7245

Tests pass on prod:

➜  storagecontrol git:(feat_storage_control) ✗ ../testing/vendor/bin/phpunit -c phpunit.xml.dist
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

Warning:       XDEBUG_MODE=coverage or xdebug.mode=coverage has to be set

.                                                                   1 / 1 (100%)

Time: 00:03.340, Memory: 10.00 MB

OK (1 test, 2 assertions)
➜  storagecontrol git:(feat_storage_control) ✗

@vishwarajanand
Copy link
Owner Author

Should've raised this on main repo, not the forked one.

@vishwarajanand vishwarajanand deleted the feat_storage_control branch April 30, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@vishwarajanand