Call this._setDefaults to set agent defaults #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 371
馃挍 - Coveralls |
|
@rimiti Can this get into the next update? |
|
@rimiti As @bdharrington7 said, it has been a while. Can this be merged? I am happy to make any changes if there are any problems. |
|
Thanks @ozzywalsh and @bdharrington7 for your contribution. This nice feature has been merged and released: https://github.com/visionmedia/supertest/releases/tag/v4.0.0 馃殌 |
|
Strange, there was already a a PR open since the end of 2017 with this exact same change: #453 How come this one was merged so fast but that one sat languishing? Well thanks for merging this regardless. |
|
Because this PR was more recent and without conflicts. 馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #538
Suggestions welcome. 馃槃
Especially the tests.