Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rimraf to v4 #1588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mojoaxel
Copy link
Member

@mojoaxel mojoaxel commented Mar 9, 2023

npm run clean still works but needs the -g parameter.

this replaces #1583

@mojoaxel mojoaxel requested a review from a team March 9, 2023 21:41
Copy link
Member

@Thomaash Thomaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing: When you delete the \", you're using the shell's globbing (who knows how that is implemented as the shell can be Dash, Bash, Zsh, Fish, cmd.exe or whatever's the developer using). It will only fall through to rimraf's globing if nothing is found and the shell doesn't choke on the glob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants