Rolling mode API enhancements #1609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpfoster
force-pushed
the
rollingMode-api-enhancements
branch
3 times, most recently
from
934f103
to
405029e
Compare
bpfoster
force-pushed
the
rollingMode-api-enhancements
branch
from
405029e
to
a1081d7
Compare
- Add explicit enable/disable methods to timeline - Add method to check if rollingMode is enabled - Fire events when rollingMode is enabled or disabled - Allow disabling of the built-in rollingMode button
bpfoster
force-pushed
the
rollingMode-api-enhancements
branch
from
a1081d7
to
b793d48
Compare
Turning it on via setOptions() already worked but not the opposite. fixes visjs#939
bpfoster
force-pushed
the
rollingMode-api-enhancements
branch
from
b793d48
to
9decbd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration... some additions that I think will help make rollingMode even more great.
Open to any/all feedback. I've got a use case for these features so I hope they'll be considered useful!