Escape spaces in paths in directories in the classpath in the generated Manifest file #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st file with %20 escape chars, so that directories with spaces in the names do not cause runtime failures.
tresat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had been using this plugin very successfully to work around Windows path length limitations in my Kotlin project, and was surprised when a clean checkout of my project failed to run on a new machine. Eventually, I cracked open the mfjars classpath jar which was being used to launch the program and looked at the Class-Path in the Manifest.MF file. I noticed there were spaces in the paths (the user name on this new machine is "FirstName LastName") which were causing the issue.
I did some testing with a local build of this plugin, and if it converts any spaces in the paths to the URL space escape charactor %20 it will fix this issue. I also bumped the version to 0.2.0 to reflect the change.
Can you please merge and publish? Thank you for all your work on this, it was very useful to find such an easy solution for that issue.