Implement choices as Literal for PyDantic #1033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the field has choices, create a Literal from the choices chore: - Temporarily disable mypy, because of the limited scope of pre-commit, mypy flags the changed function as untyped and this can't be ignored or suppressed
For possibly large fields (like all timezones) add the ability to exclude some of the choice fields.
If we set the types to Literal, PyDantic must receive the literal values, not the Enum instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to render choices as Literals, with a
choices_excludemeta configuration to exclude fields that should not be literals.