fix(take): do not consume one extra element when finishing (#224)

* fix(take): do not consume an extra element when enough number of elements are taken * fix ci failure
vitaly-t · Jul 23, 2023 · 089898c · 089898c
1 parent 7d5d329
commit 089898c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/ops/take.ts b/src/ops/take.ts
@@ -36,9 +36,10 @@ function takeSync<T>(iterable: Iterable<T>, count: number): Iterable<T> {
                 finished: boolean;
             return {
                 next(): IteratorResult<T> {
+                    finished = finished || index++ >= count;
                     if (!finished) {
                         const a = i.next();
-                        finished = a.done || index++ >= count;
+                        finished = !!a.done;
                         if (!finished) {
                             return a;
                         }
@@ -61,11 +62,12 @@ function takeAsync<T>(
                 finished: boolean;
             return {
                 next(): Promise<IteratorResult<T>> {
+                    finished = finished || index++ >= count;
                     if (finished) {
                         return Promise.resolve({value: undefined, done: true});
                     }
                     return i.next().then((a) => {
-                        finished = a.done || index++ >= count;
+                        finished = !!a.done;
                         return finished ? {value: undefined, done: true} : a;
                     });
                 }