Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tests #37

Merged
merged 5 commits into from May 14, 2023
Merged

feat: add tests #37

merged 5 commits into from May 14, 2023

Conversation

userquin
Copy link
Member

This PR includes:

  • update pnpm to 8.5.0 and Nuxt 3.4.3
  • build and browser tests for nuxi build and generate

supersedes #35

@userquin
Copy link
Member Author

userquin commented May 13, 2023

@danielroe for Nuxt ecosystem-ci:

import { runInRepo } from '../utils'
import { RunOptions } from '../types'

export async function test(options: RunOptions) {
	if (options.viteMajor < 4) {
		// only latest version
		return
	}

	await runInRepo({
		...options,
		repo: 'vite-pwa/nuxt',
		branch: 'userquin/feat-add-tests', // <== change to main when merged
		beforeTest: 'pnpm playwright install',
		build: ['dev:prepare', 'prepack'],
		test: 'test',
	})
}

@userquin userquin requested a review from danielroe May 13, 2023 12:27
package.json Outdated Show resolved Hide resolved
Co-authored-by: Daniel Roe <daniel@roe.dev>
@dargmuesli
Copy link
Contributor

Why superseding my PR 😄 🥲

.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de>
@userquin userquin merged commit c8bc92a into main May 14, 2023
@userquin userquin deleted the userquin/feat-add-tests branch May 14, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants