Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warn when mdx plugin is after the plugin #100

Merged
merged 1 commit into from May 8, 2023
Merged

fix: warn when mdx plugin is after the plugin #100

merged 1 commit into from May 8, 2023

Conversation

ArnaudBarre
Copy link
Member

Closes #81

@ArnaudBarre ArnaudBarre merged commit 0c0b7ed into main May 8, 2023
1 check passed
@brillout
Copy link

brillout commented May 8, 2023

LGTM. Although maybe I'd even throw Error() since AFAICT we're confident it won't work?

@ArnaudBarre
Copy link
Member Author

Oups didn't saw it was 1 minute ago.
Yeah that's a good point

@ArnaudBarre ArnaudBarre deleted the warn-mdx branch May 8, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brillout brillout brillout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArnaudBarre @brillout