Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop jsxPure #129

Merged
merged 2 commits into from Mar 30, 2023
Merged

chore!: drop jsxPure #129

merged 2 commits into from Mar 30, 2023

Conversation

ArnaudBarre
Copy link
Member

This is a really niche custom property that is passed down to esbuild. If you need it, set jsxSideEffects: true in the esbuild config directly.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how small usage this has, this could be done in this major. I think it may not be a bad idea to add a message if jsxPure is defined in the config though to point people to use jsxSideEffects (at least having the message during the next major).

@ArnaudBarre ArnaudBarre merged commit 7663e92 into main Mar 30, 2023
7 checks passed
@ArnaudBarre ArnaudBarre deleted the drop-jsx-pure branch March 30, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants