Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable hot reloading if in a WebWorker #181

Merged
merged 2 commits into from Jun 19, 2023

Conversation

siefkenj
Copy link
Contributor

Description

Related to issue #152 If React is used in a WebWorker (for instance when using a web worker to render static HTML), plugin-react will error because of the use of window, which is unavailable in WebWorkers. This patch disables hot reloading when in a WebWorker, which will hopefully prevent the crashes.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ArnaudBarre ArnaudBarre changed the title Disable hot reloading if in a WebWorker fix: disable hot reloading if in a WebWorker Jun 18, 2023
Copy link
Member

@ArnaudBarre ArnaudBarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also update the if statement for the footer

@ArnaudBarre
Copy link
Member

Thanks I will merge this later tonight, update the issues and release a new version

@siefkenj
Copy link
Contributor Author

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants