Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove expect error message #129

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

sapphi-red
Copy link
Member

Description

This PR fixes https://github.com/vitejs/vite-ecosystem-ci/actions/runs/4401589281/jobs/7707930360#step:8:419

vitejs/vite#12324 removed passing e.stack to server.config.logger.error. So THROW_MESSAGE is no longer output.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 50e3512 into main Mar 13, 2023
@patak-dev patak-dev deleted the chore/remove-expect-error branch March 13, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants