fix(html): rewrite assets url in <noscript> (#11764)

vitejs · Feb 18, 2023 · 1dba285 · 1dba285
1 parent 70729c0
commit 1dba285
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/packages/vite/src/node/plugins/html.ts b/packages/vite/src/node/plugins/html.ts
@@ -169,6 +169,7 @@ export async function traverseHtml(
   // lazy load compiler
   const { parse } = await import('parse5')
   const ast = parse(html, {
+    scriptingEnabled: false, // parse inside <noscript>
     sourceCodeLocationInfo: true,
     onParseError: (e: ParserError) => {
       handleParseError(e, html, filePath)

diff --git a/playground/assets/__tests__/assets.spec.ts b/playground/assets/__tests__/assets.spec.ts
@@ -409,3 +409,10 @@ test.skip('url() contains file in publicDir, as inline style', async () => {
   // (I built the playground to verify)
   expect(await getBg('.inline-style-public')).toContain(iconMatch)
 })
+
+test.runIf(isBuild)('assets inside <noscript> is rewrote', async () => {
+  const indexHtml = readFile('./dist/foo/index.html')
+  expect(indexHtml).toMatch(
+    /<img class="noscript" src="\/foo\/assets\/asset-\w+\.png" \/>/,
+  )
+})
diff --git a/playground/assets/index.html b/playground/assets/index.html
@@ -314,6 +314,12 @@ <h3>style in svg</h3>
     />
   </g>
 </svg>
+
+<h3>assets in noscript</h3>
+<noscript>
+  <img class="noscript" src="./nested/asset.png" />
+</noscript>
+
 <link rel="stylesheet" href="asset/style.css" />
 <div class="relative-css">link style</div>
 <div class="relative-js"></div>