Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: sanitize asset filenames (#9737)
- Loading branch information
Showing
8 changed files
with
93 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
27 changes: 27 additions & 0 deletions
27
playground/assets-sanitize/__tests__/assets-sanitize.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import { expect, test } from 'vitest' | ||
import { getBg, isBuild, page, readManifest } from '~utils' | ||
|
||
if (!isBuild) { | ||
test('importing asset with special char in filename works in dev', async () => { | ||
expect(await getBg('.plus-circle')).toContain('+circle.svg') | ||
expect(await page.textContent('.plus-circle')).toMatch('+circle.svg') | ||
expect(await getBg('.underscore-circle')).toContain('_circle.svg') | ||
expect(await page.textContent('.underscore-circle')).toMatch('_circle.svg') | ||
}) | ||
} else { | ||
test('importing asset with special char in filename works in build', async () => { | ||
const manifest = readManifest() | ||
const plusCircleAsset = manifest['+circle.svg'].file | ||
const underscoreCircleAsset = manifest['_circle.svg'].file | ||
expect(await getBg('.plus-circle')).toMatch(plusCircleAsset) | ||
expect(await page.textContent('.plus-circle')).toMatch(plusCircleAsset) | ||
expect(await getBg('.underscore-circle')).toMatch(underscoreCircleAsset) | ||
expect(await page.textContent('.underscore-circle')).toMatch( | ||
underscoreCircleAsset | ||
) | ||
expect(plusCircleAsset).toMatch('/_circle') | ||
expect(underscoreCircleAsset).toMatch('/_circle') | ||
expect(plusCircleAsset).not.toEqual(underscoreCircleAsset) | ||
expect(Object.keys(manifest).length).toBe(3) // 2 svg, 1 index.js | ||
}) | ||
} |
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<script type="module" src="./index.js"></script> | ||
<style> | ||
.test-el { | ||
background-repeat: no-repeat; | ||
padding-left: 2rem; | ||
margin-bottom: 1rem; | ||
} | ||
</style> | ||
<h1>test elements below should show circles and their url</h1> | ||
<div class="test-el plus-circle"></div> | ||
<div class="test-el underscore-circle"></div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import plusCircle from './+circle.svg' | ||
import underscoreCircle from './_circle.svg' | ||
function setData(classname, file) { | ||
const el = document.body.querySelector(classname) | ||
el.style.backgroundImage = `url(${file})` | ||
el.textContent = file | ||
} | ||
setData('.plus-circle', plusCircle) | ||
setData('.underscore-circle', underscoreCircle) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"name": "test-assets-sanitize", | ||
"private": true, | ||
"version": "0.0.0", | ||
"scripts": { | ||
"dev": "vite", | ||
"build": "vite build", | ||
"debug": "node --inspect-brk ../../packages/vite/bin/vite", | ||
"preview": "vite preview" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
const { defineConfig } = require('vite') | ||
|
||
module.exports = defineConfig({ | ||
build: { | ||
//speed up build | ||
minify: false, | ||
target: 'esnext', | ||
assetsInlineLimit: 0, | ||
manifest: true | ||
} | ||
}) |