Skip to content

Commit

Permalink
fix: Supplement the "preserveSymlinks" parameter of the "nestedResolv…
Browse files Browse the repository at this point in the history
…eFrom" function
  • Loading branch information
ygj6 committed Sep 13, 2021
1 parent 284170e commit 5b15546
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/resolve.ts
Expand Up @@ -457,7 +457,7 @@ export function tryNodeResolve(

// nested node module, step-by-step resolve to the basedir of the nestedPath
if (nestedRoot) {
basedir = nestedResolveFrom(nestedRoot, basedir)
basedir = nestedResolveFrom(nestedRoot, basedir, preserveSymlinks)
}

const pkg = resolvePackageData(pkgId, basedir, preserveSymlinks)
Expand Down
12 changes: 9 additions & 3 deletions packages/vite/src/node/utils.ts
Expand Up @@ -68,11 +68,15 @@ export function resolveFrom(
* like `resolveFrom` but supports resolving `>` path in `id`,
* for example: `foo > bar > baz`
*/
export function nestedResolveFrom(id: string, basedir: string): string {
export function nestedResolveFrom(
id: string,
basedir: string,
preserveSymlinks = false
): string {
const pkgs = id.split('>').map((pkg) => pkg.trim())
try {
for (const pkg of pkgs) {
basedir = resolveFrom(pkg, basedir)
basedir = resolveFrom(pkg, basedir, preserveSymlinks)
}
} catch {}
return basedir
Expand Down Expand Up @@ -296,7 +300,9 @@ export function numberToPos(
): { line: number; column: number } {
if (typeof offset !== 'number') return offset
if (offset > source.length) {
throw new Error(`offset is longer than source length! offset ${offset} > length ${source.length}`);
throw new Error(
`offset is longer than source length! offset ${offset} > length ${source.length}`
)
}
const lines = source.split(splitRE)
let counted = 0
Expand Down

0 comments on commit 5b15546

Please sign in to comment.