fix: special handling for ssr.noExternal in mergeConfig (#4766)

vitejs · Aug 30, 2021 · 689a2c8 · 689a2c8
1 parent bf0b631
commit 689a2c8
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/playground/ssr-webworker/vite.config.js b/packages/playground/ssr-webworker/vite.config.js
@@ -8,5 +8,16 @@ module.exports = {
   ssr: {
     target: 'webworker',
     noExternal: true
-  }
+  },
+  plugins: [
+    {
+      config() {
+        return {
+          ssr: {
+            noExternal: ['this-should-not-replace-the-boolean']
+          }
+        }
+      }
+    }
+  ]
 }
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts
@@ -657,6 +657,8 @@ function mergeConfigRecursively(
       } else if (key === 'assetsInclude' && rootPath === '') {
         merged[key] = [].concat(existing, value)
         continue
+      } else if (key === 'noExternal' && existing === true) {
+        continue
       }
     }