fix: --https get ignored in preview (#4318)

vitejs · Jul 20, 2021 · a870584 · a870584
1 parent 3a97644
commit a870584
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/vite/src/node/cli.ts b/packages/vite/src/node/cli.ts
@@ -211,7 +211,8 @@ cli
             logLevel: options.logLevel,
             server: {
               open: options.open,
-              strictPort: options.strictPort
+              strictPort: options.strictPort,
+              https: options.https
             }
           },
           'serve',
@@ -222,7 +223,6 @@ cli
           cleanOptions(options) as {
             host?: string
             port?: number
-            https?: boolean
           }
         )
       } catch (e) {

diff --git a/packages/vite/src/node/preview.ts b/packages/vite/src/node/preview.ts
@@ -18,13 +18,13 @@ import { resolveHostname } from './utils'
 
 export async function preview(
   config: ResolvedConfig,
-  serverOptions: { host?: string; port?: number; https?: boolean }
+  serverOptions: { host?: string; port?: number }
 ): Promise<void> {
   const app = connect() as Connect.Server
   const httpServer = await resolveHttpServer(
     config.server,
     app,
-    serverOptions.https === false ? undefined : await resolveHttpsConfig(config)
+    await resolveHttpsConfig(config)
   )
 
   // cors