docs: update comments

vitejs · Mar 16, 2023 · a8c3869 · a8c3869
1 parent 084b664
commit a8c3869
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/vite/src/node/ssr/ssrExternal.ts b/packages/vite/src/node/ssr/ssrExternal.ts
@@ -278,7 +278,6 @@ function cjsSsrCollectExternals(
     // trace the dependencies of linked packages
     else if (!esmEntry.includes('node_modules')) {
       const pkgPath = resolvePkgJsonPath(id, root)
-      // NOTE (temp): if pkg not found, we skip instead of error, is this problematic?
       if (pkgPath) {
         depsToTrace.add(path.dirname(pkgPath))
       }
@@ -292,7 +291,6 @@ function cjsSsrCollectExternals(
     // for now, we'll just leave this as is
     else if (/\.m?js$/.test(esmEntry)) {
       const pkgPath = resolvePkgJsonPath(id, root)
-      // NOTE (temp): if pkg not found, we skip instead of error, is this problematic?
       if (!pkgPath) {
         continue
       }

diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts
@@ -592,7 +592,9 @@ export const removeDir = isWindows
     }
 export const renameDir = isWindows ? promisify(gracefulRename) : fs.renameSync
 
-// `fs.realpathSync.native` has a bug in Windows network drive that prepends a slash
+// `fs.realpathSync.native` resolves differently in Windows network drive,
+// causing file read errors. skip for now.
+// https://github.com/nodejs/node/issues/37737
 export const safeRealpathSync = isWindows
   ? fs.realpathSync
   : fs.realpathSync.native