chore: core review feedback

playground/ssr-resolve/__tests__/ssr-resolve.spec.ts

@@ -1,14 +1,13 @@
 import { expect, test } from 'vitest'
-import { isBuild, testDir } from '~utils'
+import { isBuild, readFile, testDir } from '~utils'
 
 test.runIf(isBuild)('correctly resolve entrypoints', async () => {
-  const { default: output } = await import(`${testDir}/dist/main.mjs`)
+  const contents = readFile('dist/main.mjs')
 
-  expect(output).toMatchInlineSnapshot(`
-    "
-      Matches: 5,7
-      React: 18.2.0
-      Lodash: true
-    "
-  `)
+  const _ = `['"]`
+  expect(contents).toMatch(new RegExp(`from ${_}entries/dir/index.js${_}`))
+  expect(contents).toMatch(new RegExp(`from ${_}entries/file.js${_}`))
+  expect(contents).toMatch(new RegExp(`from ${_}pkg-exports/entry${_}`))
+
+  await expect(import(`${testDir}/dist/main.mjs`)).resolves.toBeTruthy()
 })

playground/ssr-resolve/entries/dir/index.js

@@ -0,0 +1 @@
+module.exports = __filename.slice(__filename.lastIndexOf('entries'))

playground/ssr-resolve/entries/file.js

@@ -0,0 +1 @@
+module.exports = __filename.slice(__filename.lastIndexOf('entries'))

playground/ssr-resolve/entries/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "entries",
+  "private": true,
+  "version": "0.0.0"
+}

playground/ssr-resolve/main.js

@@ -1,12 +1,12 @@
-// no `exports` key, should resolve to autosuggest-highlight/match/index.js
-import match from 'autosuggest-highlight/match'
-// no `exports` key, should resolve to lodash/isInteger.js
-import isInteger from 'lodash/isInteger'
-// has `exports` key, should resolve to react-dom/server
-import { version } from 'react-dom/server'
+// no `exports` key, should resolve to entries/dir/index.js
+import dirEntry from 'entries/dir'
+// no `exports` key, should resolve to entries/file.js
+import fileEntry from 'entries/file'
+// has `exports` key, should resolve to pkg-exports/entry
+import pkgExportsEntry from 'pkg-exports/entry'
 
 export default `
-  Matches: ${match('some text', 'te')}
-  React: ${version}
-  Lodash: ${isInteger(42)}
+  entries/dir: ${dirEntry}
+  entries/file: ${fileEntry}
+  pkg-exports/entry: ${pkgExportsEntry}
 `

playground/ssr-resolve/package.json

@@ -7,9 +7,7 @@
     "debug": "node --inspect-brk ../../packages/vite/bin/vite build"
   },
   "dependencies": {
-    "autosuggest-highlight": "3.3.4",
-    "lodash": "4.17.21",
-    "react": "18.2.0",
-    "react-dom": "18.2.0"
+    "entries": "file:./entries",
+    "pkg-exports": "file:./pkg-exports"
   }
 }

playground/ssr-resolve/pkg-exports/entry.js

@@ -0,0 +1 @@
+module.exports = 'pkg-exports entry'

playground/ssr-resolve/pkg-exports/index.js

@@ -0,0 +1 @@
+module.exports = undefined

playground/ssr-resolve/pkg-exports/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "pkg-exports",
+  "private": true,
+  "version": "0.0.0",
+  "exports": {
+    ".": "./index.js",
+    "./entry": "./entry.js"
+  }
+}

playground/ssr-resolve/vite.config.js

@@ -3,9 +3,6 @@ import { defineConfig } from 'vite'
 
 export default defineConfig({
   build: {
-    ssr: true,
-    rollupOptions: {
-      input: resolve(__dirname, 'main.js')
-    }
+    ssr: './main.js'
   }
 })