fix(config): skip resolve builtin modules (#10420)

vitejs · Oct 12, 2022 · ecba3f8 · ecba3f8
1 parent f248e65
commit ecba3f8
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 11 deletions.
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts
@@ -25,6 +25,7 @@ import {
   createDebugger,
   createFilter,
   dynamicImport,
+  isBuiltin,
   isExternalUrl,
   isObject,
   lookupFile,
@@ -984,7 +985,7 @@ async function bundleConfigFile(
 
           build.onResolve({ filter: /.*/ }, ({ path: id, importer, kind }) => {
             // externalize bare imports
-            if (id[0] !== '.' && !isAbsolute(id)) {
+            if (id[0] !== '.' && !path.isAbsolute(id) && !isBuiltin(id)) {
               let idFsPath = tryNodeResolve(id, importer, options, false)?.id
               if (idFsPath && (isESM || kind === 'dynamic-import')) {
                 idFsPath = pathToFileURL(idFsPath).href
@@ -1115,7 +1116,3 @@ export function isDepsOptimizerEnabled(
     (command === 'serve' && disabled === 'dev')
   )
 }
-
-function isAbsolute(id: string) {
-  return path.isAbsolute(id) || path.posix.isAbsolute(id)
-}
diff --git a/playground/cli-module/package.json b/playground/cli-module/package.json
@@ -8,5 +8,8 @@
     "build": "vite build",
     "debug": "node --inspect-brk ../../packages/vite/bin/vite",
     "serve": "vite preview"
+  },
+  "devDependencies": {
+    "url": "^0.11.0"
   }
 }
diff --git a/playground/cli-module/vite.config.js b/playground/cli-module/vite.config.js
@@ -1,5 +1,11 @@
+// eslint-disable-next-line import/no-nodejs-modules
+import { URL } from 'url'
 import { defineConfig } from 'vite'
 
+// make sure bundling works even if `url` refers to the locally installed
+// `url` package instead of the built-in `url` nodejs module
+globalThis.__test_url = URL
+
 export default defineConfig({
   server: {
     host: 'localhost'

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml