Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customize ErrorOverlay #10234

Merged
merged 1 commit into from Sep 28, 2022

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Sep 24, 2022

Description

As maintainer of Qwik, i would love to customize some aspects of the magnific ErrorOverlay:

Additional context

  • Moving the CSS variables to the host element is the right way to declare CSS variables, this way it's possible to override the default values, this is a common practice in WC UI libraries.

  • Declaring parts is a risk free API to target WC and style inner parts of a WC!

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 25, 2022
Copy link
Contributor

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL.

@patak-dev patak-dev merged commit fe4dc8d into vitejs:main Sep 28, 2022
@patak-dev patak-dev added this to the 3.2 milestone Sep 28, 2022
@patak-dev
Copy link
Member

patak-dev commented Sep 28, 2022

Let's have this one in 3.2 👍🏼
Thanks a lot for the feature @manucorporat!

@manucorporat
Copy link
Contributor Author

Thank you @patak-dev !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants