v3.2.0 missing output #10735

DerYeger · 2022-10-31T12:32:40Z

Describe the bug

After upgrading to v3.2.0 or later, vite build no longer outputs CSS files and is missing JS (except barebones IIFE).

Reproduction

https://github.com/DerYeger/vue-masonry-wall/tree/ae1b3b4586a8b0eba96e56997fce34ecd39dd0f2

Steps to reproduce

Run yarn install && yarn build && yarn demo:build

System Info

System:
    OS: macOS 13.1
    CPU: (8) arm64 Apple M1
    Memory: 444.34 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.18.0 - ~/.volta/tools/image/node/16.18.0/bin/node
    Yarn: 1.22.19 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn
    npm: 8.19.2 - ~/.volta/tools/image/node/16.18.0/bin/npm
  Browsers:
    Chrome: 107.0.5304.87
    Firefox: 104.0
    Safari: 16.1
  npmPackages:
    @vitejs/plugin-vue: 3.2.0 => 3.2.0
    vite: 3.2.1 => 3.2.1

Used Package Manager

yarn

Logs

Expected

build:demo: vite v3.1.8 building for production...
build:demo: transforming...
build:demo: ✓ 24 modules transformed.
build:demo: rendering chunks...
build:demo: dist/index.html                  1.13 KiB
build:demo: dist/assets/index.306b3559.css   2.84 KiB / gzip: 0.99 KiB
build:demo: dist/assets/index.34650a52.js    63.97 KiB / gzip: 25.68 KiB

With v3.2.0

vite v3.2.1 building for production...
transforming...
✓ 24 modules transformed.
rendering chunks...
dist/index.html                 1.07 KiB
dist/assets/index.891d93e6.js   0.69 KiB / gzip: 0.39 KiB

Validations

Follow our Code of Conduct
Read the Contributing Guidelines.
Read the docs.
Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
The provided reproduction is a minimal reproducible example of the bug.

The text was updated successfully, but these errors were encountered:

sapphi-red · 2022-10-31T13:16:03Z

It seems Vite is respecting the sideEffects field of the root package.json. I think this is a correct behavior.
Placing package.json including { "sideEffects": true } at demo directory worked.

DerYeger · 2022-10-31T13:37:53Z

It seems Vite is respecting the sideEffects field of the root package.json. I think this is a correct behavior.
Placing package.json including { "sideEffects": true } at demo directory worked.

That does indeed solve the issue, thanks!
I must have missed the changelog of Vite now picking up the sideEffects property.

Though it does work in dev mode.

sapphi-red · 2022-11-01T04:17:26Z

It doesn't happen in dev mode because Vite doesn't do the tree shake in dev mode.

bluwy · 2022-11-01T06:27:03Z

I didn't know Vite is now respecting the sideEffects field. Does this mean there's a solution for #4389 now? I'm also not sure if this counts as a regression as we don't support sideEffects before.

sodatea · 2022-11-02T08:27:56Z

Vite has always respected sideEffects since 2.0 00c57fc

I think #4389 is something different

tzimmermann · 2022-11-11T12:24:43Z

@sodatea In react-stick's demo page, we also saw the behaviour described here only after upgrading from 3.1.8 to 3.2.0.
In case it helps

the last working vercel deployment on vite 3.1.8 (the JS bundle is ~128kB):
https://react-stick-o70kfm9oe-signavio.vercel.app/
the first broken vercel deployment just after merging the vite 3.2.0 upgrade shows a white page (the JS bundle is <1kB and only contains some module loading boilerplate code):
https://react-stick-c0igwspqb-signavio.vercel.app/

Removing sideEffects: false fixed the issue, but I wanted to mention it anyway, as there seems to have been some kind of change in 3.2.0 that surfaced this bug.

guoyunhe · 2022-11-25T08:53:09Z

I believe the change is from v3.2.0. And it is a regression. sideEffects: false causes empty output, which it shouldn't.

Use `import` instead of <script> Ref vitejs/vite#10735

* refactor: update types and cleanup dependencies - Update @textlint/ast-node-types - Export extends `TxtNode` - Require Node.js 14+ - Now, output ES2018+ codes - Remove CLI - You can use a website * CI: update node versions * CI: Update Node versions * docs: remove CLI * CI: use Node 16 * CI: use Node 18 * refactor: use dual package * fix: import .js * fix: avoid vite `sideEffects` bug Use `import` instead of <script> Ref vitejs/vite#10735 * chore: add .js * fix: work on ESM * make ES2020 * fix types * CI: add .github/release.yml * fix: debug log * chore: remove snowpack * chore: remove unused pkg * fix: use import type * fix: cleanup unused functions * update * update * update * update * Update * Update

fregante · 2023-02-13T08:49:11Z

If you need another repro, you can find it in refined-github/github-url-detection#157

I'm also using sideEffects: false and it appeared at exactly 3.2.0

Also likely related in 3.2.0:

Vite removes source code on MacOS #11020

And in 2.x:

And upstream:

Rollup doesn't respect sideEffects rollup/rollup#4470

lukastaegert · 2023-02-19T06:07:16Z

Likely fix at rollup/rollup#4867

fregante · 2023-02-28T10:44:15Z

I'm testing 4.2.0 beta, with rollup 3.17.2, and I'm still not seeing any output :(

source:
https://github.com/refined-github/github-url-detection/pull/161/files
build log:
https://app.netlify.com/sites/preview-for-github-url-detection/deploys/63fdd9188e33340008789499
empty generated file:
https://deploy-preview-161--preview-for-github-url-detection.netlify.app/assets/index-3050aee0.js
output:
https://deploy-preview-161--preview-for-github-url-detection.netlify.app
expected output:
https://refined-github.github.io/github-url-detection/

Inlined log:


6:36:27 PM: Post processing - header rules
6:36:26 PM: vite v4.2.0-beta.0 building for production...
6:36:27 PM: transforming...
6:36:27 PM: ✓ 10 modules transformed.
6:36:27 PM: Post processing - redirect rules
6:36:27 PM: 10:36:27 AM [vite-plugin-svelte] dom compile done.
6:36:27 PM: package             	files	 time	  avg
6:36:27 PM: github-url-detection	    1	0.12s	0.12s
6:36:27 PM: rendering chunks...
6:36:28 PM: Post processing done
6:36:27 PM: computing gzip size...
6:36:27 PM: dist/index.html                 0.85 kB
6:36:27 PM: dist/assets/index-fbdb3af1.css  0.37 kB │ gzip: 0.27 kB
6:36:28 PM: Section completed: postprocessing
6:36:27 PM: dist/assets/index-3050aee0.js   0.71 kB │ gzip: 0.40 kB
6:36:27 PM: ✓ built in 420ms
6:36:27 PM: 
6:36:27 PM: (build.command completed in 988ms)

Note that the version is 4.2.0 beta and the JS file is a measly 710 bytes (it should be 37KB)

patak-dev · 2023-04-07T13:43:29Z

@fregante would you check with 4.3.0-beta.2? I tried to reproduce your issue in refined-github/github-url-detection but it is building correctly for me. I think it works after this PR:

fix: use nearest pkg to resolved for moduleSideEffects #12628

fregante · 2023-04-07T14:07:27Z

it is building correctly for me

The output is still sub 1KB:

❯ nr demo:build
vite v4.3.0-beta.2 building for production...
✓ 10 modules transformed.
dist/index.html                 0.85 kB │ gzip: 0.49 kB
dist/assets/index-fbdb3af1.css  0.37 kB │ gzip: 0.27 kB
dist/assets/index-3050aee0.js   0.71 kB │ gzip: 0.40 kB
✓ built in 558ms

patak-dev · 2023-04-07T14:11:43Z

Sorry for the noise, just reproduced the issue locally too 👍🏼

DerYeger added the pending triage label Oct 31, 2022

azu added a commit to textlint-rule/sentence-splitter that referenced this issue Feb 10, 2023

fix: avoid vite sideEffects bug

746be5b

Use `import` instead of <script> Ref vitejs/vite#10735

azu added a commit to textlint-rule/sentence-splitter that referenced this issue Feb 10, 2023

fix: avoid vite sideEffects bug

f182192

Use `import` instead of <script> Ref vitejs/vite#10735

fregante mentioned this issue Feb 13, 2023

Update vite once they fix a bug refined-github/github-url-detection#160

Closed

This was referenced Feb 13, 2023

Vite removes source code on MacOS #11020

Closed

Rollup doesn't respect sideEffects rollup/rollup#4470

Closed

lukastaegert mentioned this issue Feb 19, 2023

Include side effects of re-exporters unless they have no moduleSideEffects rollup/rollup#4867

Merged

9 tasks

bluwy linked a pull request Feb 21, 2023 that will close this issue

chore(deps): update rollup to 3.17.2 #12110

Merged

9 tasks

bluwy closed this as completed in #12110 Feb 22, 2023

sapphi-red reopened this Feb 28, 2023

fregante mentioned this issue Mar 9, 2023

Update dev dependencies refined-github/github-url-detection#161

Merged

jacksteamdev mentioned this issue Mar 12, 2023

Relative path with "sideEffects": false silently breaks pages crxjs/chrome-extension-tools#655

Closed

2 tasks

patak-dev mentioned this issue Apr 7, 2023

fix: ignore sideEffects for scripts imported from html #12786

Merged

4 tasks

patak-dev closed this as completed in #12786 Apr 7, 2023

github-actions bot locked and limited conversation to collaborators Apr 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v3.2.0 missing output #10735

v3.2.0 missing output #10735

DerYeger commented Oct 31, 2022

sapphi-red commented Oct 31, 2022

DerYeger commented Oct 31, 2022 •

edited

sapphi-red commented Nov 1, 2022

bluwy commented Nov 1, 2022

sodatea commented Nov 2, 2022

tzimmermann commented Nov 11, 2022 •

edited

guoyunhe commented Nov 25, 2022

fregante commented Feb 13, 2023 •

edited

lukastaegert commented Feb 19, 2023

fregante commented Feb 28, 2023

patak-dev commented Apr 7, 2023

fregante commented Apr 7, 2023

patak-dev commented Apr 7, 2023

v3.2.0 missing output #10735

v3.2.0 missing output #10735

Comments

DerYeger commented Oct 31, 2022

Describe the bug

Reproduction

Steps to reproduce

System Info

Used Package Manager

Logs

Validations

sapphi-red commented Oct 31, 2022

DerYeger commented Oct 31, 2022 • edited

sapphi-red commented Nov 1, 2022

bluwy commented Nov 1, 2022

sodatea commented Nov 2, 2022

tzimmermann commented Nov 11, 2022 • edited

guoyunhe commented Nov 25, 2022

fregante commented Feb 13, 2023 • edited

lukastaegert commented Feb 19, 2023

fregante commented Feb 28, 2023

patak-dev commented Apr 7, 2023

fregante commented Apr 7, 2023

patak-dev commented Apr 7, 2023

DerYeger commented Oct 31, 2022 •

edited

tzimmermann commented Nov 11, 2022 •

edited

fregante commented Feb 13, 2023 •

edited