fix: serialize bundleWorkerEntry #11218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
4 Windows runs passed in a row 🥳 |
poyoho
previously approved these changes
Dec 6, 2022
bluwy
reviewed
Dec 6, 2022
patak-dev
commented
Dec 6, 2022
sapphi-red
approved these changes
Dec 6, 2022
7 tasks
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@sapphi-red discovered that multiple rollup runs to bundle workers could share state, this PR serializes
bundleWorkerEntryuntil we have a better way to handle these runs in parallel. cc @poyoho @bluwyHopefully fixes the CI on Windows.
https://discord.com/channels/804011606160703521/804439875226173480/1049584735267074069
What is the purpose of this pull request?