Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested worker error #13394

Closed
wants to merge 1 commit into from
Closed

Conversation

faga295
Copy link

@faga295 faga295 commented May 31, 2023

Description

closed #13367

Seems bundleWorkerEntry wants to serialize nested workers bundle, but it blocks each other.In this pr, I replace bundleWorkerEntry with serialBundleWorkerEntry, it will recursively bundle nested workers

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented May 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

This will mean reverting:

I don't think we can do this given the current worker API. Serializing the workers is bringing other issues. See #13275, which I still don't know how to properly solve. Maybe we should consider changing the config API to use a function that returns a new array of plugins instead of a direct array for worker.plugins so we can parallelize the rollup bundling of workers again.

@faga295
Copy link
Author

faga295 commented May 31, 2023

Looking forward to these issues being properly resolved~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants