Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: customize ErrorOverlay (part 2) #11830

Merged
merged 1 commit into from Feb 22, 2023
Merged

refactor: customize ErrorOverlay (part 2) #11830

merged 1 commit into from Feb 22, 2023

Conversation

zanettin
Copy link
Contributor

@zanettin zanettin commented Jan 27, 2023 •
edited

Description

Tiny addition with missed parts from this PR. With this additions everything is visually adaptable by any frameworks to match their look'n'feel.

Additional context

Same as mentioned on #10234

What is the purpose of this pull request?

  • Bug fix
  • New Feature (extend existing feature)
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@zanettin zanettin mentioned this pull request Jan 27, 2023
Closed
@zanettin zanettin changed the title feat: customize ErrorOverlay (part 2) refactor: customize ErrorOverlay (part 2) Jan 27, 2023
@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 1, 2023
@manucorporat
Copy link
Contributor

LGTM!

@zanettin
Copy link
Contributor Author

zanettin commented Feb 2, 2023

thanks a lot @patak-dev for the approval 🙏

@zanettin zanettin mentioned this pull request Feb 3, 2023
Merged
10 tasks
@patak-dev patak-dev added this to the 4.2 milestone Feb 6, 2023
@bluwy bluwy merged commit 4159e6f into vitejs:main Feb 22, 2023
@zanettin zanettin deleted the patch-1 branch February 22, 2023 08:51
@zanettin
Copy link
Contributor Author

thx a lot @bluwy and team 🙏

futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@zanettin @futurGH
refactor: customize ErrorOverlay (part 2) (vitejs#11830)
931db4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zanettin @manucorporat @patak-dev @bluwy @sapphi-red