Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw ssr import error directly (fix #12322) #12324

Merged
merged 5 commits into from Mar 12, 2023
Merged

fix: throw ssr import error directly (fix #12322) #12324

merged 5 commits into from Mar 12, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Mar 7, 2023

Description

fix #12322

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev previously approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bluwy looks like we introduced a regression that started to swallow these errors here. The finally block was replaced by a catch there.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr regression The issue only appears after a new release labels Mar 11, 2023
bluwy
bluwy approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@patak-dev patak-dev merged commit 21ffc6a into vitejs:main Mar 12, 2023
@sapphi-red sapphi-red mentioned this pull request Mar 13, 2023
Merged
9 tasks
@fi3ework fi3ework mentioned this pull request Mar 20, 2023
Closed
7 tasks
@sapphi-red sapphi-red mentioned this pull request Mar 28, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev left review comments

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect SSR error when importing package with incorrect import paths
4 participants
@sun0day @patak-dev @bluwy @sapphi-red