Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn on build when bundling code that uses nodejs built in module #12616

Merged
merged 3 commits into from Apr 7, 2023
Merged

fix: warn on build when bundling code that uses nodejs built in module #12616

merged 3 commits into from Apr 7, 2023

Conversation

chaxus
Copy link
Contributor

@chaxus chaxus commented Mar 27, 2023

Description

Fixes #12074

Print a logger warning when packing node built-in modules

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@chaxus chaxus changed the title fix: Warn on build when bundling code that uses nodejs built in module fix: warn on build when bundling code that uses nodejs built in module Mar 27, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to log this in build since it could potentially break after deploy. We currently don't because we shim an empty module, and the runtime could never access it, but I think it's an anti-pattern in the first place that would be good to surface with this PR.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 7, 2023
@patak-dev patak-dev enabled auto-merge (squash) April 7, 2023 16:57
@patak-dev patak-dev merged commit 72050f9 into vitejs:main Apr 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on build when bundling code that uses nodejs built in module
3 participants