Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warn on build when bundling code that uses nodejs built in module #12616

Merged
merged 3 commits into from Apr 7, 2023
Merged

fix: warn on build when bundling code that uses nodejs built in module #12616

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14ffa25
fix: Warn on build when bundling code that uses nodejs built in module
chaxus Mar 27, 2023
25ae378
fix: log correctly
bluwy Apr 7, 2023
36a08ef
Merge branch 'main' into pr/chaxus/12616
bluwy Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/vite/src/node/plugins/resolve.ts
View file
Open in desktop
Expand Up @@ -382,6 +382,11 @@ export function resolvePlugin(resolveOptions: InternalResolveOptions): Plugin {
`externalized node built-in "${id}" to empty module. ` +
`(imported by: ${colors.white(colors.dim(importer))})`,
)
} else if (isProduction) {
this.warn(
`Module "${id}" has been externalized for browser compatibility, imported by "${importer}". ` +
`See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.`,
)
}
return isProduction
? browserExternalId
Expand Down