Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partial override of rollup manualChunks #5487

Closed
4 tasks done
NuckChorris opened this issue Oct 31, 2021 · 1 comment
Closed
4 tasks done

Allow partial override of rollup manualChunks #5487

NuckChorris opened this issue Oct 31, 2021 · 1 comment

Comments

@NuckChorris
Copy link

Clear and concise description of the problem

As a developer using Vite, I want to be able to override rollupOptions.manualChunks without losing the default behaviors from Vite, so that I don't have to reimplement the wonderful things Vite does for me

Suggested solution

Two solutions come to mind:

  • Exposing the default rollupOptions.manualChunks implementation so that my function can call it
  • Special-casing the rollupOptions.manualChunks option and "merging" it with the Vite default (ie, call myChunks ?? viteChunks since the function should already return undefined to use rollup defaults)

Honestly I think either would work nicely!

Alternative

No response

Additional context

No response

Validations

@patak-dev
Copy link
Member

@NuckChorris please check #6534, we are going to release it as part of vite 2.9 soon.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants