feat: support user manualChunks config #5831
Conversation
|
no need to ping. we are already getting notifications |
|
OK，excuse me
发自我的iPhone
…------------------ Original ------------------
From: Niputi ***@***.***>
Date: Thu,Nov 25,2021 5:51 PM
To: vitejs/vite ***@***.***>
Cc: yuuang ***@***.***>, Author ***@***.***>
Subject: Re: [vitejs/vite] feat: support user manualChunks config (PR #5831)
no need to ping. we are already getting notifications
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Shinigami92
added
p2-nice-to-have
Yeah... I'm not sure, but it feels like would be nice if there is a better way |
|
@zhangyuang Did you found an alternative way? |
|
@Shinigami92 I have try it but failed, so reopen it and add test in ssr-react |
zhangyuang
force-pushed
the
feat/manualChunk
branch
from
1e9ac54
to
5d869eb
Compare
|
Beside that, new impl looks much better than before 🙂 |
|
Approved it, but due to it's a |
|
OK，thanks
发自我的iPhone
…------------------ Original ------------------
From: Shinigami ***@***.***>
Date: Thu,Nov 25,2021 9:14 PM
To: vitejs/vite ***@***.***>
Cc: yuuang ***@***.***>, State change ***@***.***>
Subject: Re: [vitejs/vite] feat: support user manualChunks config (PR #5831)
Approved it, but due to it's a YAO I will bring this to next team meeting on 2021-12-03 to discuss.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Added this to discussion notes too. Sadly this is already very low (cause p2) and we have much from last meetings. So don't be up-sad if we don't get to this point in next meeting. We try our best 🙂 |
|
😄Don“t forget it #5425
发自我的iPhone
…------------------ Original ------------------
From: Shinigami ***@***.***>
Date: Thu,Nov 25,2021 9:27 PM
To: vitejs/vite ***@***.***>
Cc: yuuang ***@***.***>, State change ***@***.***>
Subject: Re: [vitejs/vite] feat: support user manualChunks config (PR #5831)
Thinking that similar issues and PRs have been created here before #5487 #5585. Is this PR necessary?
Added this to discussion notes too. Sadly this is already very low (cause p2) and we have much from last meetings. So don't be up-sad if we don't get to this point in next meeting. We try our best 🙂
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
|
Respect and understand, thank you for your efforts! 👍 |
|
Closing in favor of #5585 |
Description
Now i need a config option that
config.build.manualChunkswill be added after defaultcreateMoveToVendorChunkFnfunction called when bundle client files, if not add the option but useconfig.build.rollupOptions.manualChunkswill cover default manualChunks functionAdditional context
I need generate chunk name base on default manualChunks createMoveToVendorChunkFn function.
Or there is another way can implement my requirements？
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).