Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated api for 3.0 #5868

Merged
merged 8 commits into from May 5, 2022
Merged

refactor: remove deprecated api for 3.0 #5868

merged 8 commits into from May 5, 2022

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Nov 28, 2021

Description

Additional context

logDeprecationWarning is removed alongside with deprecated options though it is good to have that function as there can be deprecated options in the future. But, build is failing without removing that function.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ydcjeff ydcjeff mentioned this pull request Nov 28, 2021
9 tasks
@ydcjeff ydcjeff marked this pull request as ready for review November 28, 2021 08:33
@Shinigami92 Shinigami92 added this to the 3.0 milestone Nov 28, 2021
@Shinigami92 Shinigami92 self-requested a review November 28, 2021 12:24
@patak-dev patak-dev added the p1-chore Doesn't change code behavior (priority) label Apr 8, 2022
@Shinigami92
Copy link
Member

Hey @ydcjeff 👋 could you update this PR? Then we can start to review and merge it.
If there are more stuff to do, we can open additional PRs for this task.

@ydcjeff ydcjeff changed the title refactor: remove deprecated options for 3.0 refactor: remove deprecated api for 3.0 Apr 8, 2022
@Shinigami92
Copy link
Member

I will switch this PR to draft, please switch back to ready for review when finished, then I can start reviewing

@Shinigami92 Shinigami92 marked this pull request as draft April 8, 2022 14:26
@ydcjeff ydcjeff marked this pull request as ready for review April 8, 2022 15:00
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking into the code and found

packages/vite/src/node/build.ts line 425 - 432, not sure if we should somehow just ignore this property? Maybe clone the object and remove the property from the clone?

packages/vite/src/node/importGlob.ts line 31 - 36, 136+

packages/vite/src/node/server/pluginContainer.ts line 120+ 🤔

packages/vite/types/hot.d.ts line 11 - 14

packages/vite/types/importMeta.d.ts line 12 - 17

packages/vite/src/client/client.ts Outdated Show resolved Hide resolved
@ydcjeff
Copy link
Contributor Author

ydcjeff commented Apr 18, 2022

packages/vite/src/node/server/pluginContainer.ts line 120+ 🤔

This is about rollup deprecating their context function so I think we should keep this until rollup removes them?

packages/vite/src/node/build.ts line 425 - 432,

There is no output property in rollup's OutputOptions, so we can safely remove it?

@Shinigami92
Copy link
Member

pluginContainer.ts line 120+

Ah yeah, I assume it's also correct here, because we are using Omit for these. So I just thought to quickly 👍

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starts to look like ready to merge 🙂

packages/vite/src/node/build.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 dismissed their stale review April 18, 2022 06:53

there is no longer a mandatory request for a change

@Shinigami92 Shinigami92 requested a review from a team April 18, 2022 08:35
ygj6
ygj6 previously approved these changes Apr 19, 2022
Copy link
Member

@ygj6 ygj6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a global search locally and it looks good.

bluwy
bluwy previously approved these changes Apr 21, 2022
@antfu antfu added the on hold label Apr 22, 2022
@ydcjeff ydcjeff dismissed stale reviews from bluwy and ygj6 via 3715fdc April 25, 2022 11:52
@patak-dev patak-dev merged commit b5c3709 into vitejs:main May 5, 2022
@patak-dev patak-dev removed the on hold label May 5, 2022
@patak-dev
Copy link
Member

@antfu sorry, I merged the PR before seeing the on hold label. Was the label only about waiting until we start merging v3 PRs or is there something else that we should discuss about this?

@ydcjeff ydcjeff deleted the rm-deprecated branch May 5, 2022 14:46
sapphi-red added a commit to sapphi-red/vite that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change p1-chore Doesn't change code behavior (priority)
Projects
No open projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Remove @deprecated code
6 participants