Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format & check with prettier #5869

Merged
merged 1 commit into from Nov 28, 2021
Merged

chore: format & check with prettier #5869

merged 1 commit into from Nov 28, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Nov 28, 2021

Description

Ran prettier formatting and add a CI step for prettier formatting checking.

Additional context

Somehow, yorkie doesn't trigger git hooks commit-msg and pre-commit. Maybe it could only happen on my machine.
So, I sent a separate PR not to add noise in #5868


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

Prettier is also not working properly for me on commit (Windows 10), @Shinigami92 do you have any pointers for us to check?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 28, 2021

Suggestion though: should we switch to husky?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 28, 2021

Prettier is also not working properly for me on commit (Windows 10), @Shinigami92 do you have any pointers for us to check?

I think the root cause is yorkie which is used to trigger git hooks, but actually it doesn't.

@patak-dev
Copy link
Member

Suggestion though: should we switch to husky?

I'll bring this to the next team's meeting, yorkie is now more than 500+ commits behind husky 👍🏼

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Nov 28, 2021
@patak-dev patak-dev merged commit c344865 into vitejs:main Nov 28, 2021
@ydcjeff ydcjeff deleted the check-format branch November 28, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants