Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(glob): import.meta.glob support alias path #6526

Merged
merged 23 commits into from Mar 4, 2022
Merged

feat(glob): import.meta.glob support alias path #6526

merged 23 commits into from Mar 4, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Jan 16, 2022 •
edited

Description

fix: #5717
fix: #6883
duplicate of #6176

Additional context

import.meta.glob support use alias path.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho
Copy link
Member Author

poyoho commented Jan 16, 2022

@patak-dev new PR here

@poyoho
Copy link
Member Author

poyoho commented Jan 16, 2022 •
edited

it ok @patak-dev 😂

please review again

boehs
boehs previously approved these changes Jan 17, 2022
View reviewed changes
packages/vite/src/node/optimizer/scan.ts Show resolved Hide resolved
bluwy
bluwy previously approved these changes Jan 23, 2022
View reviewed changes
@poyoho poyoho changed the title feat(glob): import.meta.glob support alias path (#5717) feat(glob): import.meta.glob support alias path Feb 28, 2022
@poyoho poyoho dismissed stale reviews from bluwy and boehs via 645893c February 28, 2022 03:07
@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 28, 2022
@patak-dev patak-dev added this to the 2.9 milestone Feb 28, 2022
@patak-dev
Copy link
Member

Let's merge this one in the 2.9 beta

@patak-dev patak-dev requested a review from bluwy February 28, 2022 09:48
bluwy
bluwy previously approved these changes Feb 28, 2022
View reviewed changes
@patak-dev patak-dev merged commit 86882ad into vitejs:main Mar 4, 2022
@bluwy bluwy mentioned this pull request Mar 19, 2022
Closed
9 tasks
@poyoho poyoho deleted the feat/glob-alias branch March 20, 2022 02:12
@antfu antfu mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

@boehs boehs boehs left review comments

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

Invalid glob import syntax: pattern must start with "." or "/" import.meta.glob Not support alias
4 participants
@poyoho @patak-dev @bluwy @boehs