Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support use alias in dynamic import statements #7339

Closed
wants to merge 6 commits into from
Closed

feat: Support use alias in dynamic import statements #7339

wants to merge 6 commits into from

Conversation

caoxiemeihao
Copy link
Contributor

Description

  1. chore: remove extension restrict

The extension not be necessary during vite serve phase, because the variables in import() can be correctly resolved at runtime

  1. chroe: must be relative or root path

When i use alias in import(), it may get an absolute path like /User/name/project-path, which can work normally in the vite serve phase.

  1. feat: dynamic import support alias

When I use import(), I hope I can also support alias, which is a very common case

e.g.

// source
import(`@/views/${component}`)

// transpile
import(`/User/name/project-path/views/${component}`)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@caoxiemeihao caoxiemeihao changed the title Support use alias in dynamic import statements feat: Support use alias in dynamic import statements Mar 16, 2022
@caoxiemeihao
Copy link
Contributor Author

I write an plugin vite-plugin-dynamic-import for try enhance Vite builtin dynamic import.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 19, 2022
@caoxiemeihao
Copy link
Contributor Author

@bluwy Thanks for you help 😄

@caoxiemeihao caoxiemeihao requested a review from bluwy March 27, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants